User management interface #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dalyl09
force-pushed
the
user_management_interface
branch
2 times, most recently
from
a77d532 to
5be6aac
Compare
seanmarcia
requested changes
Feb 4, 2025
app/views/layouts/_sidebar.html.erb
Outdated
|
|
||
| <li class="sidebar-item "> | ||
| <a href="application-chat.html" class='sidebar-link'> | ||
| <a href="<%= users_path%>" class='sidebar-link'> |
Member
There was a problem hiding this comment.
We should probably use a link_to rather than an href... something like:
<%= link_to users_path, class: 'sidebar-link' do %>
<i class="bi bi-people"></i>
<span>Users</span>
<% end %>
app/views/layouts/mazer.html.erb
Outdated
|
|
||
| <body> | ||
| <!-- Only for connexion and reset password not display sidebar --> | ||
| <% unless current_page?('/connexion') || current_page?('/reset_password') %> |
Member
There was a problem hiding this comment.
I think /connexion isn't a rails convention.
app/views/layouts/mazer.html.erb
Outdated
| <body> | ||
| <!-- Only for connexion and reset password not display sidebar --> | ||
| <% unless current_page?('/connexion') || current_page?('/reset_password') %> | ||
| <%= render "layouts/sidebar" %> |
Member
There was a problem hiding this comment.
We should probably have a different layout all together for the session stuff. Like a session layout session.html.erb that is going to be specific for the password/login/etc
| root "home#index" | ||
| get "home/index", as: :home | ||
| resource :session | ||
| resources :passwords, param: :token |
Member
There was a problem hiding this comment.
Feels like we shouldn't change these away from the rails defaults.
spec/requests/users_spec.rb
Outdated
| @@ -0,0 +1,123 @@ | |||
| require "rails_helper" | |||
|
|
|||
| # This spec was generated by rspec-rails when you ran the scaffold generator. | |||
Member
There was a problem hiding this comment.
Should probably remove all the comments.
| end | ||
| end | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
extra space here can be removed
| def new | ||
| @user = User.new | ||
| end | ||
| def edit |
seanmarcia
reviewed
Feb 4, 2025
app/views/users/index.html.erb
Outdated
| <div class="card"> | ||
| <div class="card-body"> | ||
|
|
||
| <i class="bi bi-plus"></i> <%= link_to "New User?",new_user_path, class:'btn btn-primary'%> </i> |
Member
There was a problem hiding this comment.
I think you want to do this like:
<%= link_to new_region_path, class: "btn btn-primary" do %>
<i class="bi bi-plus"></i> Add New User
<% end %>
Oli0li
force-pushed
the
user_management_interface
branch
from
676b7c2 to
0a2d2b3
Compare
…gn for session/new, session controler : layout -> mazer
… password, condition in layout mazer
This commit removes/adds spaces where needed, removes unnecessary comments and changes <a> to link_to in the sidebar. There are still some other <a> in the sidebar that I haven't changed yet as other people are in the process of adding routes to these pages (Topics and Languages).
Oli0li
force-pushed
the
user_management_interface
branch
from
0a2d2b3 to
918e7b1
Compare
As per Sean's suggested changes, I have removed the "connexion" and "reset_password" routes to use the default Rails conventions. I have also fixed indendation and added some tests for login and password reset.
Oli0li
force-pushed
the
user_management_interface
branch
from
918e7b1 to
c2b6925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Issue Does This PR Cover, If Any?
Resolves #9
What Changed? And Why Did It Change?
How Has This Been Tested?
Rspec
Please Provide Screenshots
Additional Comments